Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spacebones: Improve contrast between type variable and its members #7125

Merged
merged 1 commit into from
May 26, 2023

Conversation

rsj-ioki
Copy link
Contributor

@rsj-ioki rsj-ioki commented May 24, 2023

Observe 'close' and 'open' members w.r.t type variable 'self'

Before:
image

After:
image

Better contrast between type variable and its members
@archseer
Copy link
Member

\cc @atog

Copy link
Contributor

@atog atog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@kirawi kirawi added A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer. labels May 24, 2023
@the-mikedavis the-mikedavis changed the title Better contrast between type variable and its members spacebones: Improve contrast between type variable and its members May 26, 2023
@pascalkuthe pascalkuthe merged commit 6e647e8 into helix-editor:master May 26, 2023
aotarola pushed a commit to aotarola/helix that referenced this pull request May 28, 2023
Better contrast between type variable and its members
aotarola pushed a commit to aotarola/helix that referenced this pull request May 28, 2023
Better contrast between type variable and its members
Triton171 pushed a commit to Triton171/helix that referenced this pull request Jun 18, 2023
Better contrast between type variable and its members
wes-adams pushed a commit to wes-adams/helix that referenced this pull request Jul 4, 2023
Better contrast between type variable and its members
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
Better contrast between type variable and its members
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
Better contrast between type variable and its members
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants